Probleme script bash

Programmation
#1

Salut à tous :grinning:

Voilà un petit moment que je cherche comment intégrer un monitoring de mes daemons dans mon conky .
a force de longue fouille j’ai trouvé EZ monitor qui a tous ce qu’il faut ! et meme trop pour moi justement

je cherche donc a reduire le script pour n’avoir en sortie que le résultat de " services" soit l’équivalent d’un # ./ezmonitor.sh -e
et sans l’option -e car conky ne les acceptes pas .

voici le script EZ monitor en entier

#!/bin/bash
 
# **************************************************** #
#                                                      #
#                eZ Server Monitor `sh                 #
#                                                      #
#             ***************************              #
#                                                      #
#     @name eZ Server Monitor `sh                      #
#     @author ShevAbam                                 #
#     @website ezservermonitor.com                     #
#     @created 18 Sept 2015                            #
#     @version 2.2                                     #
#                                                      #
# **************************************************** #
 
 
# ************************************************************ #
# *                        [ CONFIG ]                        * #
# ************************************************************ #
 
# Disk usage - Show or hide virtual mountpoints (tmpfs)
DISK_SHOW_TMPFS=false
 
# Service who returns WAN IP
GET_WAN_IP="http://www.ezservermonitor.com/myip"
 
# Hosts to ping
PING_HOSTS=("google.com" "facebook.com" "yahoo.com")
 
# Services port number to check
# syntax :
#   SERVICES_NAME[port_number]="label"
#   SERVICES_HOST[port_number]="localhost"
SERVICES_NAME[21]="FTP Server"
SERVICES_HOST[21]="localhost"
 
SERVICES_NAME[22]="SSH"
SERVICES_HOST[22]="localhost"
 
SERVICES_NAME[80]="Web Server"
SERVICES_HOST[80]="localhost"
 
SERVICES_NAME[3306]="Database"
SERVICES_HOST[3306]="localhost"
 
# Temperatures blocks (true for enable)
TEMP_ENABLED=false
 
 
# ********************************************************** #
# *                        [ VARS ]                        * #
# ********************************************************** #
 
# Constants -- DON'T TOUCH !!
ESM_NAME="eZ Server Monitor \`sh"
ESM_VERSION="2.2"
ESM_AUTHOR="ShevAbam"
ESM_CREATED="18 September 2015"
ESM_URL="http://www.ezservermonitor.com"
 
# Colors
NC="\e[0m"
RED="\e[31;40m"
GREEN="\e[32;40m"
YELLOW="\e[33;40m"
WHITE="\e[37;40m"
 
# Styles
BOLD="\e[1m"
RESET="\e[0m"
WHITE_ON_GREY="\e[100;97m"
 
 
# *************************************************************** #
# *                        [ FUNCTIONS ]                        * #
# *************************************************************** #
 
function makeTitle()
{
    echo -e "${BOLD}${WHITE_ON_GREY}  $1  ${RESET}"
}
 
# Function : system
function system()
{
    OS=`uname -s`
  
    if [ -e "/usr/bin/lsb_release" ] ; then
        DISTRO=`/usr/bin/lsb_release -ds`
    elif [ -e "/etc/system-release" ] ; then
        DISTRO=`cat /etc/system-release`
    else
        DISTRO=`find /etc/*-release -type f -exec cat {} \; | grep NAME | tail -n 1 | cut -d= -f2 | tr -d '"'`;
    fi
  
    HOSTNAME=`hostname`
    KERNEL_INFO=`/bin/uname -r`
   
    UPTIME=`cat /proc/uptime`
    UPTIME=${UPTIME%%.*}
    UPTIME_MINUTES=$(( UPTIME / 60 % 60 ))
    UPTIME_HOURS=$(( UPTIME / 60 / 60 % 24 ))
    UPTIME_DAYS=$(( UPTIME / 60 / 60 / 24 ))
 
    LAST_BOOT_DATE=`who -b | awk '{print $3}'`
    LAST_BOOT_TIME=`who -b | awk '{print $4}'`
 
    USERS_NB=`who | wc -l`
 
    CURRENT_DATE=`/bin/date '+%F %T'`
 
    makeTitle "System"
 
    echo -e "${GREEN}  Hostname\t   ${WHITE}$HOSTNAME"
    echo -e "${GREEN}  OS\t\t   ${WHITE}$OS $DISTRO"
    echo -e "${GREEN}  Kernel\t   ${WHITE}$KERNEL_INFO"
    echo -e "${GREEN}  Uptime\t   ${WHITE}$UPTIME_DAYS day(s), $UPTIME_HOURS hours(s), $UPTIME_MINUTES minute(s)"
    echo -e "${GREEN}  Last boot\t   ${WHITE}$LAST_BOOT_DATE $LAST_BOOT_TIME"
    echo -e "${GREEN}  Current user(s)  ${WHITE}$USERS_NB connected"
    echo -e "${GREEN}  Server datetime  ${WHITE}$CURRENT_DATE"
}
 
# Function : load average
function load_average()
{
    PROCESS_NB=`ps -e h | wc -l`
    PROCESS_RUN=`ps r h | wc -l`
 
    CPU_NB=`cat /proc/cpuinfo | grep "^processor" | wc -l`
 
    LOAD_1=`cat /proc/loadavg | awk '{print $1}'`
    # LOAD_1_PERCENT=`echo $LOAD_1 | awk '{print 100 * $1}'`
    LOAD_1_PERCENT=`echo $(($(echo $LOAD_1 | awk '{print 100 * $1}') / $CPU_NB))`
    if [ $LOAD_1_PERCENT -ge 100 ] ; then
        LOAD_1_PERCENT=100;
    fi
 
    if [ $LOAD_1_PERCENT -ge 75 ] ; then
        LOAD_1_COLOR=${RED}
    elif [ $LOAD_1_PERCENT -ge 50 ] ; then
        LOAD_1_COLOR=${YELLOW}
    else
        LOAD_1_COLOR=${WHITE}
    fi
 
    LOAD_2=`cat /proc/loadavg | awk '{print $2}'`
    # LOAD_2_PERCENT=`echo $LOAD_2 | awk '{print 100 * $1}'`
    LOAD_2_PERCENT=`echo $(($(echo $LOAD_2 | awk '{print 100 * $1}') / $CPU_NB))`
    if [ $LOAD_2_PERCENT -ge 100 ] ; then
        LOAD_2_PERCENT=100;
    fi
 
    if [ $LOAD_2_PERCENT -ge 75 ] ; then
        LOAD_2_COLOR=${RED}
    elif [ $LOAD_2_PERCENT -ge 50 ] ; then
        LOAD_2_COLOR=${YELLOW}
    else
        LOAD_2_COLOR=${WHITE}
    fi
 
    LOAD_3=`cat /proc/loadavg | awk '{print $3}'`
    # LOAD_3_PERCENT=`echo $LOAD_3 | awk '{print 100 * $1}'`
    LOAD_3_PERCENT=`echo $(($(echo $LOAD_3 | awk '{print 100 * $1}') / $CPU_NB))`
    if [ $LOAD_3_PERCENT -ge 100 ] ; then
        LOAD_3_PERCENT=100;
    fi
 
    if [ $LOAD_3_PERCENT -ge 75 ] ; then
        LOAD_3_COLOR=${RED}
    elif [ $LOAD_3_PERCENT -ge 50 ] ; then
        LOAD_3_COLOR=${YELLOW}
    else
        LOAD_3_COLOR=${WHITE}
    fi
 
    echo
    makeTitle "Load Average"
    echo -e "${GREEN}  Since 1 minute     $LOAD_1_COLOR $LOAD_1_PERCENT% ($LOAD_1)"
    echo -e "${GREEN}  Since 5 minutes    $LOAD_2_COLOR $LOAD_2_PERCENT% ($LOAD_2)"
    echo -e "${GREEN}  Since 15 minutes   $LOAD_3_COLOR $LOAD_3_PERCENT% ($LOAD_3)"
    echo -e "${GREEN}  Processus\t      ${WHITE}$PROCESS_NB process, including $PROCESS_RUN running"
}
 
# Function : CPU
function cpu()
{
    CPU_NB=`cat /proc/cpuinfo | grep -i "^processor" | wc -l`
    CPU_INFO=`cat /proc/cpuinfo | grep -i "^model name" | awk -F": " '{print $2}' | head -1 | sed 's/ \+/ /g'`
    
    CPU_FREQ=`cat /proc/cpuinfo | grep -i "^cpu MHz" | awk -F": " '{print $2}' | head -1`

    if [ -z $CPU_FREQ ] ; then
        CPU_FREQ=`cat /sys/devices/system/cpu/cpu0/cpufreq/cpuinfo_max_freq`
        CPU_FREQ=$(( $CPU_FREQ / 1000 ))
    fi
    
    CPU_CACHE=`cat /proc/cpuinfo | grep -i "^cache size" | awk -F": " '{print $2}' | head -1`
    CPU_BOGOMIPS=`cat /proc/cpuinfo | grep -i "^bogomips" | awk -F": " '{print $2}' | head -1`
 
    echo
    makeTitle "CPU"
 
    if [ $CPU_NB -gt 1 ] ; then
        echo -e "${GREEN}  Number\t ${WHITE}$CPU_NB"
    fi
    echo -e "${GREEN}  Model\t\t ${WHITE}$CPU_INFO"
    echo -e "${GREEN}  Frequency\t ${WHITE}$CPU_FREQ MHz"
    echo -e "${GREEN}  Cache L2\t ${WHITE}$CPU_CACHE"
    echo -e "${GREEN}  Bogomips\t ${WHITE}$CPU_BOGOMIPS"
}
 
# Function : memory
function memory()
{
    MEM_TOTAL=`/usr/bin/free -tmo | grep -i Mem: | awk '{print $2}'`
    MEM_FREE=`/usr/bin/free -tmo | grep -i Mem: | awk '{print $4+$6+$7}'`
 
    echo
    makeTitle "Memory"
    echo -e "${GREEN}  RAM\t\t${WHITE}$MEM_FREE Mb free of $MEM_TOTAL Mb"
}
 
# Function : network
function network()
{
    INTERFACES=`/sbin/ifconfig |awk -F '[/  |: ]' '{print $1}' |sed -e '/^$/d'`
 
    if [ -e "/usr/bin/curl" ] ; then
        IP_WAN=`curl -s ${GET_WAN_IP}`
    else
        IP_WAN=`wget ${GET_WAN_IP} -O - -o /dev/null`
    fi
 
    echo
    makeTitle "Network"
 
    for INTERFACE in $INTERFACES
    do
        IP_LAN=`/sbin/ip -f inet -o addr show ${INTERFACE} | cut -d\  -f 7 | cut -d/ -f 1`
        echo -e "${GREEN}  IP LAN (${INTERFACE})\t ${WHITE}$IP_LAN"
    done
 
    echo -e "${GREEN}  IP WAN\t ${WHITE}$IP_WAN"
}
 
# Function : ping
function ping()
{
    echo
    makeTitle "Ping"
 
    for HOST in ${PING_HOSTS[@]}
    do
        PING=`/bin/ping -qc 1 $HOST | awk -F/ '/^rtt/ { print $5 }'`
 
        echo -e "${GREEN}  ${HOST}\t ${WHITE}$PING ms"
    done
}
 
# Function : Disk space  (top 5)
function disk_space()
{
    HDD_TOP=`df -h | head -1 | sed s/^/"  "/`
    #HDD_DATA=`df -hl | grep -v "^Filesystem" | grep -v "^Sys. de fich." | sort -k5r | head -5 | sed s/^/"  "/`
    # HDD_DATA=`df -hl | sed "1 d" | grep -v "^Filesystem" | grep -v "^Sys. de fich." | sort | head -5 | sed s/^/"  "/`
 
    if [ ${DISK_SHOW_TMPFS} = true ] ; then
        HDD_DATA=`df -hl | sed "1 d" | grep -iv "^Filesystem|Sys." | sort | head -5 | sed s/^/"  "/`
    else
        HDD_DATA=`df -hl | sed "1 d" | grep -iv "^Filesystem|Sys." | grep -vE "^tmpfs|udev" | sort | head -5 | sed s/^/"  "/`
    fi
 
    echo
    makeTitle "Disk space (top 5)"
    echo -e "${GREEN}$HDD_TOP"
    echo -e "${WHITE}$HDD_DATA"
}
 
# Function : services
function services()
{
    echo
    makeTitle "Services"
 
    for PORT in "${!SERVICES_NAME[@]}"
    do
        NAME=${SERVICES_NAME[$PORT]}
        HOST=${SERVICES_HOST[$PORT]}
 
        CHECK=`(exec 3<>/dev/tcp/$HOST/$PORT) &>/dev/null; echo $?`
 
        if [ $CHECK = 0 ] ; then
            CHECK_LABEL=${WHITE}ONLINE
        else
            CHECK_LABEL=${RED}OFFLINE
        fi
 
        echo -e "${GREEN}  $NAME ($PORT) : ${CHECK_LABEL}"
    done
}
 
# Function : hard drive temperatures
function hdd_temperatures()
{
    if [ ${TEMP_ENABLED} = true ] ; then
        echo
        makeTitle "Hard drive Temperatures"
 
        DISKS=`ls /sys/block/ | grep -E -i '^(s|h)d'`
       
        # If hddtemp is installed
        if [ -e "/usr/sbin/hddtemp" ] ; then
 
            for DISK in $DISKS
            do
                TEMP_DISK=`hddtemp -n /dev/$DISK`"°C"
               
                echo -e "  ${GREEN}/dev/$DISK\t${WHITE}$TEMP_DISK"
            done
        else
            echo -e "${WHITE}\nPlease, install hddtemp${WHITE}"
        fi
    fi
}
 
# Function : system temperatures
function system_temperatures()
{
    if [ ${TEMP_ENABLED} = true ] ; then
        echo
        makeTitle "System Temperatures"

        # If lm-sensors is installed
        if [ -e "/usr/bin/sensors" ] ; then
            TEMP_CPU=`/usr/bin/sensors | grep -E "^(CPU Temp|Core 0)" | cut -d '+' -f2 | cut -d '.' -f1`"°C"
            TEMP_MB=`/usr/bin/sensors | grep -E "^(Sys Temp|Board Temp)" | cut -d '+' -f2 | cut -d '(' -f1`
        
            echo -e "  ${GREEN}CPU          ${WHITE}$TEMP_CPU"
            echo -e "  ${GREEN}Motherboard  ${WHITE}$TEMP_MB"
        # Raspberry Pi
        elif [ -f "/sys/class/thermal/thermal_zone0/temp" ] ; then
            TEMP_CPU=`cat /sys/class/thermal/thermal_zone0/temp`
            TEMP_CPU=$(( $TEMP_CPU / 1000 ))
           
            echo -e "  ${GREEN}CPU          ${WHITE}$TEMP_CPU°C"

        else
            echo -e "${WHITE}\nPlease, install lm-sensors${WHITE}"
        fi
    fi
}
 
# Function : showAll
function showAll()
{
    system
    load_average
    cpu
    memory
    network
    ping
    disk_space
    services
    hdd_temperatures
    system_temperatures
}
 
# Function : showVersion
function showVersion()
{
  echo "$ESM_VERSION"
}
 
# Function : showHelp
function showHelp()
{
  echo
  echo "-------"
  echo -e "Name    : $ESM_NAME\nVersion : $ESM_VERSION\nAuthor  : $ESM_AUTHOR\nCreated : $ESM_CREATED"
  echo
  echo -e "$ESM_NAME is originally a PHP project allows you to display system's information of a Unix machine.\nThis is the bash version."
  echo
  echo -e "[USAGE]\n"
  echo -e "  -h, -u, --help, --usage    print this help message \n"
  echo -e "  -v, --version              print program version\n"
  echo -e "  -C, --clear                clear console\n                             Must be inserted before any argument\n"
  echo -e "  -s, --system               system information (OS and distro ; kernel ; hostname ; uptime ; users connected; last boot; datetime)\n"
  echo -e "  -e, --services             checks port number\n"
  echo -e "  -n, --network              network information (IP LAN ; IP WAN)\n"
  echo -e "  -p, --ping                 pings several hosts\n                             Can be configured in the file\n"
  echo -e "  -c, --cpu                  processor information (model ; frequency ; cache ; bogomips)\n"
  echo -e "  -m, --memory               RAM information (free and total)\n"
  echo -e "  -l, --load                 system load ; processus\n"
  echo -e "  -t, --temperatures         print CPU, system and HDD temperatures\n                             Can be configured in the file\n"
  echo -e "  -d, --disk                 disk space (top 5) ; sorted by alpha\n"
  echo -e "  -a, --all                  print all data\n"
  echo; echo;
  echo -e "More information on : $ESM_URL"
  echo "-------"
  echo
}
 
 
# *************************************************************** #
# *                       [ LET'S GO !! ]                       * #
# *************************************************************** #
 
if [ $# -ge 1 ] ; then
   
    while getopts "Csenpcmltdavhu-:" option
    do
        case $option in
            h | u) showHelp; exit ;;
            v) showVersion; exit;;
            C) clear ;;
            s) system ;;
            n) network ;;
            p) ping ;;
            c) cpu ;;
            m) memory ;;
            l) load_average ;;
            t) hdd_temperatures; system_temperatures ;;
            d) disk_space ;;
            e) services ;;
            a) showAll ;;
            -) case $OPTARG in
                  help | usage) showHelp; exit ;;
                  version) showVersion; exit ;;
                  all) showAll; exit ;;
                  clear) clear ;;
                  system) system ;;
                  services) services ;;
                  load) load_average ;;
                  cpu) cpu ;;
                  memory) memory ;;
                  network) network ;;
                  ping) ping ;;
                  disk) disk_space ;;
                  temperatures) hdd_temperatures; system_temperatures ;;
                  *) exit ;;
               esac ;;
            ?) echo "Option -$OPTARG inconnue"; exit ;;
            *) exit ;;
        esac
    done
   
else
    #showAll
    showHelp;
    exit;
fi
 
echo -e "${RESET}"

et voici le script une fois réduits du superflus

 
 #!/bin/bash
# ************************************************************ #
# *                        [ CONFIG ]                        * #
# ************************************************************ #

# Services port number to check
# syntax :
#   SERVICES_NAME[port_number]="label"
#   SERVICES_HOST[port_number]="localhost"
SERVICES_NAME[53]="Unbound"
SERVICES_HOST[53]="localhost"
 
SERVICES_NAME[218]="Dnscrypt"
SERVICES_HOST[218]="localhost"
 
SERVICES_NAME[80]="SSH"
SERVICES_HOST[80]="localhost"
 
SERVICES_NAME[3306]="VPN"
SERVICES_HOST[3306]="localhost"
 
 
# ********************************************************** #
# *                        [ VARS ]                        * #
# ********************************************************** #

# Colors
NC="\e[0m"
RED="\e[31;40m"
GREEN="\e[32;40m"
YELLOW="\e[33;40m"
WHITE="\e[37;40m"
 
# Styles
BOLD="\e[1m"
RESET="\e[0m"
WHITE_ON_GREY="\e[100;97m"
 
 
# *************************************************************** #
# *                        [ FUNCTIONS ]                        * #
# *************************************************************** #



function makeTitle()
{
    echo -e "${BOLD}${WHITE_ON_GREY}  $1  ${RESET}"
}
 

# Function : services
function services()
{
    echo
    makeTitle "Services"
  
    for PORT in "${!SERVICES_NAME[@]}"
    do
        NAME=${SERVICES_NAME[$PORT]}
        HOST=${SERVICES_HOST[$PORT]}
 
        CHECK=`(exec 3<>/dev/tcp/$HOST/$PORT) &>/dev/null; echo $?`
 
        if [ $CHECK = 0 ] ; then
            CHECK_LABEL=${WHITE}ONLINE
        else
            CHECK_LABEL=${RED}OFFLINE
        fi
 
        echo -e "${GREEN}  $NAME ($PORT) : ${CHECK_LABEL}"
    done
}

a partir de là je n’arrive pas a faire en sort que echo affiche le resultat dans le terminal :anguished:
Le script d’origine passe par l’appel de fonctions et je n’arrive pas a simplifier le truc. Help! :cry:

#2

salut
il manque la première ligne
sh et bash sont différents et [ $CHECK = 0 ] me parait inhabituel en bash

#3

salut dindoun, merci de ta reponse
pour la permiere ligne "#!/bin/bash " elle est déjà présente dans mon script je ne l’avais juste pas recopier ici.
pourquoi check = 0 te parait inhabituel? le script initiale marche au poils pourtant.

#4

ce n’est pas la solution, mais
[ $CHECK = 0 ] me parait inhabituel en bash car je pensais qu’il fallait doubler le égal mais comme tu répliques un truc qui marche , ca n’est pas le problème si ton script est lancé de la même façon
en effet tu peux lancer un script par sh machin.sh ou bash machin.sh ou ./machin.sh quelquesoit ton entête mais les résultat s seront différents

solution : hector a raison,

un petit chmod +x
et hop

#5

hop! :wink:

ca marche avec et sans couleurs niquel, pour l’intégration des celle ci dans conky avoir cette nuit mais conky est en bash et les codes couleurs sont les memes a voir.

après j’ai pas compris ont est 3 sur la discustion mais je ne vois que @dindoun et moi (hector)
hors je veux bien etre fou mais pas skyzo, comment hector peut repondre a hector donc a moi en locurrence?

#!/bin/bash

SERVICES_NAME[53]="Unbound"
SERVICES_HOST[53]="localhost"
 
SERVICES_NAME[218]="Dnscrypt"
SERVICES_HOST[218]="localhost"
 
SERVICES_NAME[80]="SSH"
SERVICES_HOST[80]="localhost"
 
SERVICES_NAME[3306]="VPN"
SERVICES_HOST[3306]="localhost"

 
# Function : services
function services()
{
   
      for PORT in "${!SERVICES_NAME[@]}"
    do
        NAME=${SERVICES_NAME[$PORT]}
        HOST=${SERVICES_HOST[$PORT]}
 
        CHECK=`(exec 3<>/dev/tcp/$HOST/$PORT) &>/dev/null; echo $?`
 
        if [ $CHECK = 0 ] ; then
            CHECK_LABEL=ONLINE
        else
            CHECK_LABEL=OFFLINE
        fi
 
        echo "${CHECK_LABEL}"
    done
}
  services
#6

[quote=“Hector, post:5, topic:72900”]
…comment hector peut repondre a hector donc a moi en locurrence?…
[/quote]C’est de ma faute : J’avais cliqué sur le mauvais bouton pour répondre, et du coup, j’avais modifié, sans m’en rendre compte, le message de celui à qui je répondais.

J’ai remis le message dans son état original.

Désolé pour la gêne occasionnée.

Du coup, je remets ci-dessous le contenu du message que j’avais rédigé :

Bonjour

Dans ton script “réduit”, tu ne définis que des variables et une fonction,
mais tu ne fais appel à aucune commande ou fonction.

À la fin de ce script, ajoute une ligne appelant la fonction services définie dans ce script

Il te faudra sans doute supprimer toutes les séquences d’échappement utilisées pour la colorisation de la sortie du texte dans une fenêtre de terminal, car conky ne pourra pas les interpréter de la même façon.

Pour que le shebang puisse être pris en compte, il te faudra supprimer le premier caractère espace du fichier qui est situé avant le premier caractère #

1 J'aime